Update to Pimcore 12 and CoreShop 5 compatibility by Copilot · Pull Request #444 · instride-ch/pimcore-data-definitions

Copilot · 2026-01-23T12:31:26Z

Pimcore 12 and CoreShop 5 Compatibility Update

Update composer.json to require:
- pimcore/pimcore: ^12.3 (from ^11.0)
- pimcore/admin-ui-classic-bundle: ^2.0 (from ^1.4)
- coreshop/pimcore-bundle: ^5.0 (from ^4.0)
- coreshop/resource-bundle: ^5.0 (from ^4.0)
- coreshop/rule-bundle: ^5.0 (from ^4.0)
- php: ^8.3 (from >=8.1)
Update GitHub Actions workflows:
- Update behat.yml to use Pimcore 12.3 matrix and PHP 8.3
- Update static.yml to use Pimcore 12.3 matrix and PHP 8.3
- Update codestyles.yml branch references to 5.0 and PHP 8.3
Add Pimcore Studio React UI (ExtJS to React conversion):
- Added pimcore-studio assets directory with React/TypeScript components
- Created module federation setup with rsbuild for Pimcore Studio integration
- Implemented ImportDefinitionsPanel and ExportDefinitionsPanel components
- Implemented ImportDefinitionEditor and ExportDefinitionEditor with form handling
- Added API service for definition CRUD operations with proper error handling
- Added icon library module for Data Definitions icons
- Added menu module for Settings navigation integration
- Added TypeScript type definitions for definitions and mappings
- Added input validation and sanitization
- Moved package.json, rsbuild.config.ts, and tsconfig.json to root folder
Add Docker configuration for Pimcore Studio:
- Added docker-compose.yaml.dist with services for PHP, Nginx, MySQL, OpenSearch, and Mercure
- Added .docker/nginx.conf with Mercure proxy configuration for SSE
- Added .docker/supervisord.conf for messenger queue workers
- Added Dockerfile for development environment
- Added config/packages/pimcore_studio_backend.yaml for Mercure settings
- Added config/packages/pimcore_generic_data_index.yaml for OpenSearch settings
- Updated .env with OpenSearch and Mercure environment variables
Add GitHub Action for frontend build:
- Added frontend-build.yaml workflow that builds Studio bundle on every push
- Automatically commits built assets back to the repository
- Removed Studio build output from .gitignore so assets are tracked
Request code review
Run security scanning (no alerts found)

Original prompt

This section details on the original issue you should resolve

<issue_title>Update to Pimcore 12</issue_title>
<issue_description>Hello @dpfaffenbauer and team,

Not an issue but how about updating pimcore-data-definitions to Pimcore 12 ?

Will it be a big rework or only a composer packages update ?

Thanks.</issue_description>

<agent_instructions>make it Pimcore 12 and CoreShop 5 compatible, you can see the CoreShop studio implementation here coreshop/CoreShop#2942</agent_instructions>

Comments on the Issue (you are @copilot in this section)
@dpfaffenbauer only composer package update, Pimcore 12 is pretty much the same as 11, except the license, where we haven't decided yet if still free or paid.

Fixes Update to Pimcore 12 #443

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: dpfaffenbauer <5981845+dpfaffenbauer@users.noreply.github.com>

dpfaffenbauer · 2026-01-23T13:12:13Z

@copilot es ist besonders wichtig das der extjs Code von classic admin auf react für Studio umgebaut wird

Copilot · 2026-01-23T13:14:17Z

@copilot es ist besonders wichtig das der extjs Code von classic admin auf react für Studio umgebaut wird

I understand - you need the ExtJS admin code converted to React for Pimcore Studio. I've analyzed the existing codebase (70 ExtJS files) and the CoreShop Studio implementation pattern from PR #2942.

This involves:

Creating a new Resources/assets/pimcore-studio directory with React/TypeScript structure
Setting up npm workspaces and rsbuild configuration
Converting all panels (import/export definitions), interpreters, setters, getters, providers, and import rules to React components
Using @pimcore/studio-ui-bundle as the UI foundation

I'll start implementing the React-based Studio UI following the CoreShop pattern.

Co-authored-by: dpfaffenbauer <5981845+dpfaffenbauer@users.noreply.github.com>

dpfaffenbauer · 2026-01-23T13:51:41Z

@copilot move package json and build file in the root folder

…oot folder Co-authored-by: dpfaffenbauer <5981845+dpfaffenbauer@users.noreply.github.com>

Copilot · 2026-01-23T13:53:59Z

@copilot move package json and build file in the root folder

Done in commit 53a10f1. Moved package.json, rsbuild.config.ts, and tsconfig.json to the repository root folder. Updated paths to point to the correct source locations.

dpfaffenbauer · 2026-01-23T13:54:57Z

@copilot also adapt docker-compose and other configs to work with pimcore generic data index and mercure

…re Studio Co-authored-by: dpfaffenbauer <5981845+dpfaffenbauer@users.noreply.github.com>

Copilot · 2026-01-23T13:59:03Z

@copilot also adapt docker-compose and other configs to work with pimcore generic data index and mercure

Done in commit bf4af9f. Added Docker configuration with:

docker-compose.yaml.dist - PHP, Nginx, MySQL, OpenSearch (for Generic Data Index), and Mercure (for SSE)
.docker/nginx.conf - Mercure Hub proxy configuration
.docker/supervisord.conf - Messenger queue worker for index queues
Dockerfile - Development PHP image with xdebug
config/packages/pimcore_studio_backend.yaml - Mercure settings
config/packages/pimcore_generic_data_index.yaml - OpenSearch connection
Updated .env with OpenSearch and Mercure environment variables

dpfaffenbauer · 2026-01-23T13:59:39Z

@copilot ergänze noch die actions das der build bei jedem push gemacht wird und eingecheckt wird

Co-authored-by: dpfaffenbauer <5981845+dpfaffenbauer@users.noreply.github.com>

Copilot · 2026-01-23T14:02:08Z

@copilot ergänze noch die actions das der build bei jedem push gemacht wird und eingecheckt wird

Done in commit 7f07cc9. Added .github/workflows/frontend-build.yaml that:

Runs on every push/PR to 5.0 branch
Installs npm dependencies, runs lint and type check
Builds the Studio bundle with npm run build
Commits and pushes the built assets back to the repository

Also removed the Studio build output path from .gitignore so the assets are tracked in git.

github-actions · 2026-01-24T19:49:10Z

Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

1 out of 2 committers have signed the CLA.
✅ (dpfaffenbauer)[https://github.com/dpfaffenbauer]
❌ @Copilot
_{You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.}

dpfaffenbauer · 2026-01-24T19:49:17Z

@aarongerig please approve license change

Initial plan

0d784a1

Copilot AI assigned Copilot and dpfaffenbauer Jan 23, 2026

Copilot started work on behalf of dpfaffenbauer January 23, 2026 12:31 View session

chore: update to Pimcore 12 and CoreShop 5 compatibility

d2f3560

Co-authored-by: dpfaffenbauer <5981845+dpfaffenbauer@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Update pimcore-data-definitions to Pimcore 12~~ Update to Pimcore 12 and CoreShop 5 compatibility Jan 23, 2026

Copilot AI requested a review from dpfaffenbauer January 23, 2026 12:35

Copilot finished work on behalf of dpfaffenbauer January 23, 2026 12:35

Copilot started work on behalf of dpfaffenbauer January 23, 2026 13:12 View session

Copilot AI and others added 2 commits January 23, 2026 13:18

feat: add Pimcore Studio React UI for Data Definitions

201bd12

Co-authored-by: dpfaffenbauer <5981845+dpfaffenbauer@users.noreply.github.com>

fix: improve API error handling and input validation

eee25ea

Co-authored-by: dpfaffenbauer <5981845+dpfaffenbauer@users.noreply.github.com>

Copilot finished work on behalf of dpfaffenbauer January 23, 2026 13:22

Copilot started work on behalf of dpfaffenbauer January 23, 2026 13:52 View session

refactor: move package.json, rsbuild.config.ts and tsconfig.json to r…

53a10f1

…oot folder Co-authored-by: dpfaffenbauer <5981845+dpfaffenbauer@users.noreply.github.com>

Copilot finished work on behalf of dpfaffenbauer January 23, 2026 13:54

Copilot started work on behalf of dpfaffenbauer January 23, 2026 13:55 View session

feat: add Docker config with OpenSearch and Mercure support for Pimco…

bf4af9f

…re Studio Co-authored-by: dpfaffenbauer <5981845+dpfaffenbauer@users.noreply.github.com>

Copilot finished work on behalf of dpfaffenbauer January 23, 2026 13:59

Copilot started work on behalf of dpfaffenbauer January 23, 2026 14:00 View session

feat: add GitHub Action for frontend build on push

7f07cc9

Co-authored-by: dpfaffenbauer <5981845+dpfaffenbauer@users.noreply.github.com>

Copilot finished work on behalf of dpfaffenbauer January 23, 2026 14:03

[Studio] Migration to Pimcore Studio :)

7b252d3

[Studio] Migration to Pimcore Studio :)

d44d4a0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to Pimcore 12 and CoreShop 5 compatibility#444

Update to Pimcore 12 and CoreShop 5 compatibility#444
Copilot wants to merge 9 commits into5.0from
copilot/update-to-pimcore-12

Copilot AI commented Jan 23, 2026 •

edited

Loading

Uh oh!

dpfaffenbauer commented Jan 23, 2026

Uh oh!

Copilot AI commented Jan 23, 2026

Uh oh!

dpfaffenbauer commented Jan 23, 2026

Uh oh!

Copilot AI commented Jan 23, 2026

Uh oh!

dpfaffenbauer commented Jan 23, 2026

Uh oh!

Copilot AI commented Jan 23, 2026

Uh oh!

dpfaffenbauer commented Jan 23, 2026

Uh oh!

Copilot AI commented Jan 23, 2026

Uh oh!

github-actions bot commented Jan 24, 2026

Uh oh!

dpfaffenbauer commented Jan 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Copilot AI commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pimcore 12 and CoreShop 5 Compatibility Update

Comments on the Issue (you are @copilot in this section)

Uh oh!

dpfaffenbauer commented Jan 23, 2026

Uh oh!

Copilot AI commented Jan 23, 2026

Uh oh!

dpfaffenbauer commented Jan 23, 2026

Uh oh!

Copilot AI commented Jan 23, 2026

Uh oh!

dpfaffenbauer commented Jan 23, 2026

Uh oh!

Copilot AI commented Jan 23, 2026

Uh oh!

dpfaffenbauer commented Jan 23, 2026

Uh oh!

Copilot AI commented Jan 23, 2026

Uh oh!

github-actions bot commented Jan 24, 2026

Uh oh!

dpfaffenbauer commented Jan 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Jan 23, 2026 •

edited

Loading